Skip to content

🎨 Palette: Improve filter button accessibility and eliminate FOUC #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EffortlessSteven wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

🎨 Palette: Improve filter button accessibility and eliminate FOUC #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b51518
🎨 Palette: Improve filter button accessibility and eliminate FOUC
EffortlessSteven Mar 26, 2026
3bb5dc2
🎨 Palette: Improve filter button accessibility and eliminate FOUC
EffortlessSteven Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 14 additions & 25 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/adapters-db-sqlx/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tracing.workspace = true
uuid.workspace = true

[dev-dependencies]
testcontainers = "0.26.0"
testcontainers = "0.27.2"
uuid = {features = ["v4"], workspace = true}
async-trait.workspace = true
chrono.workspace = true
Expand Down
19 changes: 9 additions & 10 deletions crates/app-http/src/platform/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,11 +688,14 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
function filterData(status) {
currentFilter = status;

// Update active button
// Update active button and aria-pressed
document.querySelectorAll('.filter-btn').forEach(btn => {
btn.classList.remove('active');
btn.setAttribute('aria-pressed', 'false');
});
document.getElementById('filter-' + status).classList.add('active');
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');

// Apply filter
applyFilters();
Expand Down Expand Up @@ -768,10 +771,6 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
});
}

// Initialize with 'all' filter active
window.addEventListener('DOMContentLoaded', () => {
document.getElementById('filter-all').classList.add('active');
});
"#))
}

Expand Down Expand Up @@ -800,10 +799,10 @@ pub async fn coverage_view(State(state): State<AppState>) -> Html<String> {
.card {
h2 { "Acceptance Criteria Coverage" }
.filter-controls data-uiid="coverage.filters" {
button #filter-all.filter-btn onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
button #filter-all.filter-btn.active aria-pressed="true" onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn aria-pressed="false" onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn aria-pressed="false" onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn aria-pressed="false" onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
oninput="searchData()";
}
Expand Down
21 changes: 10 additions & 11 deletions crates/http-platform/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ fn dashboard_content(
fn coverage_content() -> Markup {
html! {
style { (coverage_styles()) }
script { (coverage_script()) }
script { (maud::PreEscaped(coverage_script())) }

.card data-uiid="coverage.summary" {
h2 { "AC Coverage Summary" }
Expand All @@ -621,10 +621,10 @@ fn coverage_content() -> Markup {
.card {
h2 { "Acceptance Criteria Coverage" }
.filter-controls data-uiid="coverage.filters" {
button #filter-all.filter-btn onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn onclick="filterData('unknown')" { "Unknown" }
button #filter-all.filter-btn.active aria-pressed="true" onclick="filterData('all')" { "All" }
button #filter-passing.filter-btn aria-pressed="false" onclick="filterData('passing')" { "Passing" }
button #filter-failing.filter-btn aria-pressed="false" onclick="filterData('failing')" { "Failing" }
button #filter-unknown.filter-btn aria-pressed="false" onclick="filterData('unknown')" { "Unknown" }
input #search-box.search-box type="text" placeholder="Search by AC ID or title..."
oninput="searchData()";
}
Expand Down Expand Up @@ -763,11 +763,14 @@ fn coverage_script() -> &'static str {
function filterData(status) {
currentFilter = status;

// Update active button
// Update active button and aria-pressed
document.querySelectorAll('.filter-btn').forEach(btn => {
btn.classList.remove('active');
btn.setAttribute('aria-pressed', 'false');
});
document.getElementById('filter-' + status).classList.add('active');
const activeBtn = document.getElementById('filter-' + status);
activeBtn.classList.add('active');
activeBtn.setAttribute('aria-pressed', 'true');

// Apply filter
applyFilters();
Expand Down Expand Up @@ -831,9 +834,5 @@ fn coverage_script() -> &'static str {
});
}

// Initialize with 'all' filter active
window.addEventListener('DOMContentLoaded', () => {
document.getElementById('filter-all').classList.add('active');
});
"#
}
Loading