Skip to content

⚡ Bolt: [performance improvement] Eliminate unnecessary heap allocations in redact_string#292

Draft
EffortlessSteven wants to merge 3 commits intomainfrom
bolt-redact-cow-allocations-12867709291929586689
Draft

⚡ Bolt: [performance improvement] Eliminate unnecessary heap allocations in redact_string#292
EffortlessSteven wants to merge 3 commits intomainfrom
bolt-redact-cow-allocations-12867709291929586689

Conversation

@EffortlessSteven
Copy link
Copy Markdown
Member

💡 What: Updated redact_string to use Cow when performing regex replacements.
🎯 Why: The previous code was calling .to_string() on the results, which unconditionally allocated a new String object via the Display trait regardless of whether a regex match was actually found. By using Cow::Borrowed and checking for Cow::Owned to indicate a replacement happened, we avoid allocating when there are no secret matches.
📊 Impact: Eliminates unneeded heap allocations when running redact_string, reducing garbage and making the function strictly zero-allocation for non-matching secrets (the common case).
🔬 Measurement: Run unit tests / benchmarks in crates/xchecker-redaction. Tested via cargo test -p xchecker-redaction.


PR created automatically by Jules for task 12867709291929586689 started by @EffortlessSteven

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 23, 2026

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80ca5299-8379-4ba6-9d9c-f047683abee1

📥 Commits

Reviewing files that changed from the base of the PR and between 4138f8e and 7d34574.

📒 Files selected for processing (3)
  • .jules/bolt.md
  • crates/xchecker-redaction/src/lib.rs
  • tests/test_unix_process_termination.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt-redact-cow-allocations-12867709291929586689

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Increased timeout buffer and used `try_wait` directly on the child instead of the old `is_process_running` wrapper which relied on `kill(pid, 0)` that could report true for zombie processes.
1. Wait briefly before sending SIGTERM to ensure the shell trap is fully registered.
2. Change sleep 30 to a while loop with sleep 1 to ensure standard shell behavior handling traps without 'exec' optimization issues replacing the handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant