🎨 Palette: Add keyboard controls hint and ARIA labels#187
Conversation
- Added `aria-live` and `aria-atomic` to `#score` for screen readers. - Added visible text to inform users about keyboard jumping shortcuts, kept outside `aria-live` region to avoid screen-reader repetition. - Fixed pip package issues with requirements.txt Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Added visible instructions for keyboard jumping in
mario-game.njkand improved accessibility by addingaria-livecapabilities to the#scoreupdates. Removed thevenvdefault python package fromrequirements.txtto fix CI pip installation.🎯 Why
New players had to guess the controls since the game captures
SpaceandArrowUpnatively. Making these instructions visible directly improves UX for sighted users while proper ARIA tags improve the experience for visually impaired users.📸 Before/After
Before: The score updated silently for screen readers, and controls were hidden.
After: The score updates are politely read out to the screen reader, and static, visibly styled instructional text resides under the score.
♿ Accessibility
aria-live="polite"andaria-atomic="true"to#scoreso that updates are broadcasted.aria-hidden="true"element so it doesn't double-read out.PR created automatically by Jules for task 17286121334430296918 started by @EiJackGH