Skip to content

🎨 Palette: Add game accessibility and keyboard hints#191

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-a11y-hints-12199535075071960749
Open

🎨 Palette: Add game accessibility and keyboard hints#191
EiJackGH wants to merge 2 commits into
mainfrom
palette/mario-game-a11y-hints-12199535075071960749

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added crucial accessibility improvements and visual keyboard hints to the Mario game widget.

🎯 Why

  • Discoverability: Previously, the game's jump mechanics (Space or Up Arrow) were completely hidden. Now there is explicit, unobtrusive instructional text beneath the score so users immediately know how to interact.
  • Accessibility: The dynamic score wasn't being announced to screen readers. We added ARIA live region attributes so visually impaired users can track their progress as the score increases.

♿ Accessibility

  • Added aria-live="polite" and aria-atomic="true" to the #score element.
  • Crucially: Extracted the static keybinding instructions into a separate, non-live sibling element so screen readers don't repetitively announce "Press Space or Up Arrow to jump" every single time the score goes up.

PR created automatically by Jules for task 12199535075071960749 started by @EiJackGH

…ario Game

* Added `aria-live="polite"` and `aria-atomic="true"` to the score `#score` div to ensure score updates are smoothly announced to screen readers.
* Extracted static keybindings instructions ("Press Space or Up Arrow to jump") out into a separate, visible `<div id="instructions">` sibling, improving UX discoverability and keeping screen reader announcements focused purely on the dynamic score changes.
* Added corresponding `#instructions` positioning CSS.
* Logged a critical a11y learning to the Palette journal regarding `aria-live` region best practices.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…ario Game

* Added `aria-live="polite"` and `aria-atomic="true"` to the score `#score` div to ensure score updates are smoothly announced to screen readers.
* Extracted static keybindings instructions ("Press Space or Up Arrow to jump") out into a separate, visible `<div id="instructions">` sibling, improving UX discoverability and keeping screen reader announcements focused purely on the dynamic score changes.
* Added corresponding `#instructions` positioning CSS.
* Fixed CI failure by removing the invalid `venv` dependency from `requirements.txt`.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant