Skip to content

🎨 Palette: Add keyboard instructions and ARIA attributes#195

Open
EiJackGH wants to merge 2 commits into
mainfrom
palette-a11y-mario-game-14672026034166272008
Open

🎨 Palette: Add keyboard instructions and ARIA attributes#195
EiJackGH wants to merge 2 commits into
mainfrom
palette-a11y-mario-game-14672026034166272008

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What

Added a visible instructions overlay indicating the required keyboard controls ("Press Space or Up Arrow to jump") and added aria-live="polite" and aria-atomic="true" to the dynamic score counter.

🎯 Why

Previously, new users had to guess the controls to play the game, leading to initial frustration. Additionally, the score updates were completely invisible to users relying on screen readers because the text changed dynamically without any semantic announcement flags.

📸 Before/After

(See attached screenshot verifying the new visual instructions overlay in the top-right corner).

♿ Accessibility

  • Made the score updates accessible to assistive technologies using aria-live="polite".
  • Improved cognitive accessibility by making the interaction mechanics explicitly clear.

PR created automatically by Jules for task 14672026034166272008 started by @EiJackGH

- Added visual instructions overlay for keyboard controls
- Added aria-live and aria-atomic attributes to score container

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Added visual instructions overlay for keyboard controls
- Added aria-live and aria-atomic attributes to score container
- Removed problematic `venv` dependency from `requirements.txt` to fix CI pip installation failure

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant