Split undefined bug - Subrip files that has CR+LF#6
Open
MasoudRahmani wants to merge 5 commits intoEldinZenderink:masterfrom
Open
Split undefined bug - Subrip files that has CR+LF#6MasoudRahmani wants to merge 5 commits intoEldinZenderink:masterfrom
MasoudRahmani wants to merge 5 commits intoEldinZenderink:masterfrom
Conversation
Better Handling of line split. supports CR+LF. "line" var will always have 1 line(child).
Update SubPlayerJS.js
rawgit will close down!
Update demo.html
If each line in subrip file is ended with CR+LF, split doesn't work properly, therefore we need to remove all "CR".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SRT files that their each line end with CR+LF don't work with current algorithm because each dialog is not grouped in one line and therefore text and timing is not separated.
for this code to work we need to have only "LF" .
also rawgit is closing down, so i changed to jsdeliver.