Adding log rotation using lumberjack#423
Open
sergey3bv wants to merge 2 commits intoElementsProject:masterfrom
Open
Adding log rotation using lumberjack#423sergey3bv wants to merge 2 commits intoElementsProject:masterfrom
sergey3bv wants to merge 2 commits intoElementsProject:masterfrom
Conversation
YusukeShimizu
requested changes
Feb 24, 2026
Contributor
YusukeShimizu
left a comment
YusukeShimizu
left a comment
There was a problem hiding this comment.
Thank you for the log rotation update; this is a valuable improvement overall.
I have one concern that looks blocking, so I’m marking this as request changes for now and would appreciate a quick confirmation.
sergey3bv
force-pushed
the
feat/log-rotation
branch
from
9c3993a to
659b3f0
Compare
Author
|
Hey, @YusukeShimizu, I updated the PR accordingly, could you please review it? Also are there any issues I can help with? |
sergey3bv
force-pushed
the
feat/log-rotation
branch
from
659b3f0 to
eda6a6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@YusukeShimizu
@nepet
Addressing #301