Skip to content

# bugs found and fixed #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elena-Nam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

# bugs found and fixed #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const correctMessage = document.getElementById('correct');

let targetNumber;
let attempts = 0;
const maxNumberOfAttempts = 5;
let maxNumberOfAttempts = 5; // const changed into let //

// Returns a random number from min (inclusive) to max (exclusive)
// Usage:
Expand All @@ -34,7 +34,7 @@ function checkGuess() {
numberOfGuessesMessage.innerHTML = `You made ${attempts} guesses`;

correctMessage.style.display = '';

resetButton.disabled = true; // added the reset button//
submitButton.disabled = true;
guessInput.disabled = true;
}
Expand All @@ -43,7 +43,7 @@ function checkGuess() {
if (guess < targetNumber) {
tooLowMessage.style.display = '';
} else {
tooLowMessage.style.display = '';
tooHighMessage.style.display = ''; // changed from low to high//
}

const remainingAttempts = maxNumberOfAttempts - attempts;
Expand All @@ -52,36 +52,51 @@ function checkGuess() {
numberOfGuessesMessage.innerHTML = `You guessed ${guess}. <br> ${remainingAttempts} guesses remaining`;
}

if (attempts ==== maxNumberOfAttempts) {
if (attempts === maxNumberOfAttempts) {
submitButton.disabled = true;
guessInput.disabled = true;
// added 2 lines wuth numberOfGuessesMessages//
numberOfGuessesMessage.style.display = '';
numberOfGuessesMessage.innerHTML =`0 guesses remaining`;
resetButton.disabled = false; //added the reset button//
}

// added a new condition //
if (attempts === 4) {
numberOfGuessesMessage.style.display = '';
numberOfGuessesMessage.innerHTML =`1 guess remaining`;
resetButton.disabled = false;
}


guessInput.value = '';

resetButton.style.display = '';
}

// in the loop <= was changed into < //
function hideAllMessages() {
for (let elementIndex = 0; elementIndex <= messages.length; elementIndex++) {
for (let elementIndex = 0; elementIndex < messages.length; elementIndex++) {
messages[elementIndex].style.display = 'none';
}
}

funtion setup() {
function setup() {
// Get random number
targetNumber = getRandomNumber(1, 100);
console.log(`target number: ${targetNumber}`);

// Reset number of attempts
maxNumberOfAttempts = 0;

maxNumberOfAttempts = 5;// changed from 0 to 5 again//
attempts = 0; // added the number of attemps again //

// Enable the input and submit button
submitButton.disabeld = false;
submitButton.disabled = false;
guessInput.disabled = false;
guessInput.value = ''; // added a clear input again //

hideAllMessages();
resetButton.style.display = 'none';
resetButton.disabled = true;
}

submitButton.addEventListener('click', checkGuess);
Expand Down