add support in Dropdown for creating new options using allowCreateOptions prop#1107
Merged
anserwaseem merged 1 commit intomainfrom Sep 11, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 2b90498 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Visit the preview URL for this PR (updated for commit 2b90498): https://react-kitchen-sink-dev--pr1107-1103-support-creatin-lczdiq3l.web.app (expires Thu, 18 Sep 2025 16:38:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
16c1cf1 to
2b90498
Compare
justEhmadSaeed
approved these changes
Sep 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
allowCreateOptionsprop.onChange(or Ant Design'sonFieldsChange) fires consistently, we introduced a helper that leverages Ant Design's internalRC_FORM_INTERNAL_HOOKS.dispatch.RC_FORM_INTERNAL_HOOKS), which may change in future versions.Alternative approaches like
Form.useWatchwere considered, but were rejected due to performance trade-offs.This implementation keeps the change localized to the Dropdown widget and avoids diffing the entire form on every update.
Screenshots [Optional]
er-1103.mov
Issue ticket number and link
Closes #1103
Checklist before requesting a review
pnpm changeset add