[repo meta] formatting & addition of pre-commit configuration#153
Closed
whi-tw wants to merge 2 commits intoEtteGit:mainfrom
Closed
[repo meta] formatting & addition of pre-commit configuration#153whi-tw wants to merge 2 commits intoEtteGit:mainfrom
pre-commit configuration#153whi-tw wants to merge 2 commits intoEtteGit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on
ercf.pyin #150, I noticed that the file had quite a lot of formatting quirks, which I was constantly fighting with in my IDE.I have reformatted the file with the latest version of black and also removed a lot of trailing whitespace.
Additionally I've added configuration for pre-commit which could potentially prevent things from getting messy again. I've only run it on
ercf.pyso far, hopefully if people use the pre-commit hook in future, everything will gradually be tidied up.pre-commitcan be run locally (docs on the website above) and automatically for free with a CI check via https://pre-commit.ci/ (requires setup on @EtteGit's side).