Open
Conversation
this update adds define I2C_CUSTOM_PINS, I2C_SDA, I2C_SCL to enable custom pin to be used for i2c communication.
EvanBottango
requested changes
Feb 26, 2025
Owner
EvanBottango
left a comment
EvanBottango
left a comment
There was a problem hiding this comment.
Super appreciate the pull request! No objection to the core idea, just want to move the I2C_CUSTOM_PINS flag from modules to config. Thanks!
Owner
There was a problem hiding this comment.
I like where your head is at, but this flag belongs in BottangoArduinoConfig.h instead of BottangoArduinoModules.h
Modules File == Enable and disable major functionality blocks.
Config File == tweak the operation of functionality.
Since this doesn't enable a major functionality block, but just tweaks how the pcadriver setup is called, feels like it's a config option, not a module.
Author
There was a problem hiding this comment.
Ok, now I see where your coming from, was unsure what to define where.
Enable custom i2c Pins via ArduinoConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this update adds define I2C_CUSTOM_PINS, I2C_SDA, I2C_SCL to enable custom pin to be used for i2c communication.