Fix issue 427 #433
Fix issue 427 #433
Conversation
nmummau
force-pushed
the
issue/427
branch
2 times, most recently
from
eab1b52 to
e3ce8bd
Compare
|
I'd prefer to split those, especially when it comes to docker compose updates. No need to do it with this one, it's ok. The reason is that I'd definitely accept the fix, but docker compose change seems discussable. Using Also, samples don't need two framework targets, one is enough. Using just .NET 9 is fine. |
|
Also, where the actual fix? I only see the props file changed to add .NET 9 and the rest is changes in docker compose. |
nmummau
force-pushed
the
issue/427
branch
5 times, most recently
from
0dc79e0 to
06ba2a2
Compare
This change resolves a code smell comparing a BIGINT to an INT.
This is safe and the correct thing to do because SqlServerStreamSubscription PrepareCommand() already is handling parsing this to an int:
protected override SqlCommand PrepareCommand(SqlConnection connection, long start)
=> connection.GetStoredProcCommand(Schema.ReadStreamSub)
.Add("@stream_id", SqlDbType.Int, _streamId)
.Add("@stream_name", SqlDbType.NVarChar, _streamName)
.Add("@from_position", SqlDbType.Int, (int)start + 1)
.Add("@count", SqlDbType.Int, Options.MaxPageSize);
|
@alexeyzimarev I rebased and cleaned this up. It's now an isolated fix to fix issue #427, along with an update to the TargetFramework for the samples. |
Test Results 15 files ±0 15 suites ±0 2h 58m 5s ⏱️ + 2h 20m 56s For more details on these failures, see this check. Results for commit 7a6be43. ± Comparison against base commit 4f9b060. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
* chore: bump samples to use net9.0
* fix(mssql): change from_position to int
This change resolves a code smell comparing a BIGINT to an INT.
This is safe and the correct thing to do because SqlServerStreamSubscription PrepareCommand() already is handling parsing this to an int:
protected override SqlCommand PrepareCommand(SqlConnection connection, long start)
=> connection.GetStoredProcCommand(Schema.ReadStreamSub)
.Add("@stream_id", SqlDbType.Int, _streamId)
.Add("@stream_name", SqlDbType.NVarChar, _streamName)
.Add("@from_position", SqlDbType.Int, (int)start + 1)
.Add("@count", SqlDbType.Int, Options.MaxPageSize);
2 participants
This fixes issue #427
Also included are is a net9 framework target, and some docker compose cleanup