Skip to content

Conversation

@SilverDorian46
Copy link
Contributor

This allows the user to conditionally play a custom vignette before the next scene is instantiated

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Oct 7, 2025
@JaThePlayer
Copy link
Member

I think the event should return a Scene?, which PlayCustomVignette will set Engine.Scene to if not null. Sounds good otherwise.

@SilverDorian46
Copy link
Contributor Author

I think the event should return a Scene?, which PlayCustomVignette will set Engine.Scene to if not null. Sounds good otherwise.

now that I think about it, yes. I'll try changing it in a moment

@SnipUndercover
Copy link
Member

Will approve once the TAS check syncs just in case, otherwise looks good.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Dec 2, 2025, 12:56 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Nov 29, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Dec 2, 2025
@SnipUndercover SnipUndercover merged commit 6e8d841 into EverestAPI:dev Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants