Add a "database mirror" option for people that cannot access maddie480.ovh #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480-bot
added
the
1: review needed
JaThePlayer
approved these changes
Nov 14, 2025
DashingCat
suggested changes
Nov 16, 2025
Contributor
DashingCat
left a comment
DashingCat
left a comment
There was a problem hiding this comment.
I agree with adding this option, but I believe adding logging could be useful to check from the log file if the database mirror was enabled or not.
| private static readonly object _getUpdaterURLLock = new object(); | ||
|
|
||
| private static string GetEverestUpdaterDatabaseURL() { | ||
| if (CoreModule.Settings.UseAPIMirror) return "https://everestapi.github.io/updatermirror/everest_versions.json"; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (CoreModule.Settings.UseAPIMirror) return "https://everestapi.github.io/updatermirror/everest_versions.json"; | |
| if (CoreModule.Settings.UseAPIMirror) { | |
| Logger.Info("updater", "Using API mirror to get Everest Updater database URL"); | |
| return "https://everestapi.github.io/updatermirror/everest_versions.json"; | |
| } |
maddie480
added
the
4: should be squashed
DashingCat
approved these changes
Nov 17, 2025
maddie480
force-pushed
the
api-mirror
branch
from
1160da7 to
a8613a7
Compare
maddie480
removed
the
4: should be squashed
Wartori54
reviewed
Nov 18, 2025
Member
Wartori54
left a comment
Wartori54
left a comment
There was a problem hiding this comment.
Just a minor logging change, other than that LGTM.
Wartori54
approved these changes
Nov 18, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Co-authored-by: Wartori <72220838+Wartori54@users.noreply.github.com>
maddie480
force-pushed
the
api-mirror
branch
from
677be85 to
6b8929a
Compare
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, Russians (or at least some of them) can't access my website anymore or something? So, here is a new option to get the mod updater database straight from everestapi.github.io. It is updated as frequently as the actual one at maddie480.ovh.