Fix format parameter not being passed to handler #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaThePlayer
approved these changes
Nov 23, 2025
Member
Author
|
Since this is a bug that has already gotten into stable, I think this warrants skipping the last-call period and merging directly to dev. Discussed in #modding_dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted values inside of interpolated strings will not have their format applied, as the
LogInterpolatedStringHandlerclass (and its generic variant) did not pass theformatargument inAppendFormatted<T>overloads that included it. This meant that the format would not be applied.Tested with @2cm - they compiled Everest with this patch and it seemed to work.