Show more verbose messages on duplicate tileset IDs #1026
Merged
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480-bot
added
the
1: review needed
microlith57
approved these changes
Nov 27, 2025
microlith57
approved these changes
Nov 27, 2025
JaThePlayer
requested changes
Nov 29, 2025
Member
JaThePlayer
left a comment
JaThePlayer
left a comment
There was a problem hiding this comment.
Just a tiny change needed, looks good otherwise
maddie480-bot
added
2: changes requested
JaThePlayer
approved these changes
Nov 29, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. |
maddie480-bot
added
3: last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
Autotilerconstructor explicitly throw when a duplicate tileset ID is encountered. It also shows a new postcard when applicable. The Unicode code point is also printed in case the tileset ID happens to be an unprintable character, as several people reported that high tileset IDs (such asU+5337) turn into?(U+003F) when viewed inlog.txt.IL patch, decompiled
Postcard
Logged exception