Remove dependency hot loading #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature caused a lot of problems for people than it was worth
convenience-wise.
- Virtually no mod expects to be hot loaded in this way, and can likely
crash even after the try/catches in OuiDependencyDownloader
- Crashes interrupt the download/update process, often making users
stuck with a configuration of mods and everest that kills the game
on bootup until they update from outside the game
- Lots of people make #modding_help reports of crashes when downloading
dependencies that are fixed by restarting
- The state of the game at the time of hot loading is not the same as
the state of the game at the time of a cold boot, potentially making
mods not fully initialize
- Take the following scenario:
- The user has mod A enabled that optionally depends on mod C
- The user installs mod B that requires C to be present
- When downloading dependencies, C will be downloaded and loaded
*after* A, even though A optionally depends on C and needs to load
after C if present.
This can cause unexpected behavior if the user did not restart
after installing deps.
Co-authored-by: microlith57 <microlith57@gmail.com>
Member
Author
|
It just occurred to me that users could still encounter crashes after restarting.
Should we be concerned about this? EDIT: Actually, new ExtVars will probably depend on a newer version of MHH to prevent the crash, so this is probably a non-issue. |
maddie480-bot
added
the
1: review needed
DashingCat
approved these changes
Dec 7, 2025
Wartori54
approved these changes
Dec 7, 2025
Member
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
maddie480-bot
added
3: last call window
Member
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
maddie480-bot
added
4: ready to merge
Contributor
|
good riddance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature caused a lot of problems for people than it was worth convenience-wise.
Virtually no mod expects to be hot loaded in this way, and can likely crash even after the try/catches in
OuiDependencyDownloaderCrashes interrupt the download/update process, often making users stuck with a configuration of mods and Everest that kills the game on bootup until they update from outside the game
Lots of people make
#modding_helpreports of crashes when downloading dependencies that are fixed by restartingThe state of the game at the time of hot loading is not the same as the state of the game at the time of a cold boot, potentially making mods not fully initialize
Take the following scenario:
This can cause unexpected behavior if the user did not restart after installing deps.