Skip to content

Conversation

@grog398
Copy link
Contributor

@grog398 grog398 commented Dec 9, 2025

Does exactly what the title says, ILCursorExtensions logging makes the logfile extremely cluttered, and is, well, extremely verbose. Changing the loglevel here would allow for LogLevel.Debug to be more useful and easier to read for codemodders.

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Dec 9, 2025
@SnipUndercover
Copy link
Member

SnipUndercover commented Dec 9, 2025

The motivation behind making these debug was to provide an easier at-a-glance way to tell whether cursor matching is not done correctly. However with more mods using these extensions it was made clear that the match failure logs could be a cause of unnecessary log spam, so I agree with making those (lines 172 and 423) verbose.

I still want to keep the start/end logs in debug to give the user the option to see or hide the detailed matching steps by changing the log levels in modsettings-Everest.celeste.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Dec 14, 2025, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Dec 10, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Dec 14, 2025
@SnipUndercover SnipUndercover merged commit 10f8717 into EverestAPI:dev Dec 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants