Skip to content

fix(collab): stop /documents/:slug/ops replaying stale DB markdown into live rooms #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devYRPauli wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −8
Open

fix(collab): stop /documents/:slug/ops replaying stale DB markdown into live rooms #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions server/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,20 +1728,18 @@ apiRoutes.post('/documents/:slug/ops', opsRateLimiter, async (req: Request, res:

if (result.status >= 200 && result.status < 300) {
// Collab mutations for rewrite.apply are committed through the canonical Yjs path.
// Other ops still need explicit projection sync into the live room.
// Other (engine-backed) ops only refresh presence/cursor coupling below; they do not
// push a DB snapshot into the live room.
if (op !== 'rewrite.apply') {
try {
const collabRuntime = getCollabRuntime();
if (collabRuntime.enabled) {
const updatedDoc = getDocumentBySlug(slug);
if (updatedDoc) {
const applyOptions = {
markdown: typeof updatedDoc.markdown === 'string' ? updatedDoc.markdown : undefined,
marks: parseJson(updatedDoc.marks),
source: 'rest-ops',
};
await applyCanonicalDocumentToCollab(slug, applyOptions);

// Route-level reapplication from the DB can replay stale markdown over concurrent
// live edits that are not yet persisted, so engine-backed (non-rewrite.apply) ops
// no longer push a broad DB snapshot into the live room. Only the narrow,
// non-content presence/cursor coupling below is synced.
if (participation) {
try {
applyAgentPresenceToLoadedCollab(slug, participation.presenceEntry, {
Expand Down