Skip to content

refactor stuff while working on another task#771

Open
joanise wants to merge 4 commits intomainfrom
dev.ej/refactor-stuff
Open

refactor stuff while working on another task#771
joanise wants to merge 4 commits intomainfrom
dev.ej/refactor-stuff

Conversation

@joanise
Copy link
Member

@joanise joanise commented Feb 24, 2026

PR Goal?

Do some code clean up and refactoring while I'm working on another project.

Spliced into a separate PR for easier reviewing.

Fixes?

  • BaseModel.json() has been deprecated, use the current model_dump_json() function instead;
  • typer documentation now recommends using Annotated[] for declaring arguments with a base type and additional type metadata: converted everyvoice/cli.py to use this syntax;
  • enabled "no args is help" so that everyvoice and everyvoice train, e.g., are now equivalent to everyvoice -h and everyvoice train -h.
  • test_utils, once it accidentally leaves a directory behind, keeps failing systematically afterwards. Give the developer an explicit warning about that and instructions on how to fix it before rerunning the tests.

Confidence?

high

Version change?

no

Related PRs?

no

@semanticdiff-com
Copy link

semanticdiff-com bot commented Feb 24, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/tests/test_utils.py  67% smaller
  everyvoice/cli.py  24% smaller
  everyvoice/base_cli/checkpoint.py  0% smaller

@joanise joanise changed the title Dev.ej/refactor stuff refactor stuff while working on another task Feb 24, 2026
@github-actions
Copy link
Contributor

CLI load time: 0:00.25
Pull Request HEAD: e395a9708cc0406f941eba5998bd234b417282be
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      8900 |     139278 | everyvoice.cli

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.76%. Comparing base (4d9652d) to head (e395a97).

Files with missing lines Patch % Lines
everyvoice/base_cli/checkpoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          47       47           
  Lines        4119     4119           
  Branches      607      607           
=======================================
  Hits         3409     3409           
  Misses        579      579           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant