Open
Conversation
typer now says to prefer Annotated over typer.Option and typer.Argument with a default value. This commit applies this recommendation in a lot of instances.
Changed Files
|
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 47 47
Lines 4119 4119
Branches 607 607
=======================================
Hits 3409 3409
Misses 579 579
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Do some code clean up and refactoring while I'm working on another project.
Spliced into a separate PR for easier reviewing.
Fixes?
BaseModel.json()has been deprecated, use the currentmodel_dump_json()function instead;Annotated[]for declaring arguments with a base type and additional type metadata: convertedeveryvoice/cli.pyto use this syntax;everyvoiceandeveryvoice train, e.g., are now equivalent toeveryvoice -handeveryvoice train -h.test_utils, once it accidentally leaves a directory behind, keeps failing systematically afterwards. Give the developer an explicit warning about that and instructions on how to fix it before rerunning the tests.Confidence?
high
Version change?
no
Related PRs?
no