Support MLA YaRN RoPE scaling parameters#151
Open
zhujian19891203 wants to merge 1 commit into
Open
Conversation
Add original_max_position_embeddings and expose beta_fast/beta_slow for MLA YaRN RoPE, use mscale_all_dim for softmax scaling, and avoid rejecting checkpoint loads when only max_position_embeddings changes. Local-port-of: f1a85bad9e7f05c4fa80c81181e44414e1ac8ab7 Upstream-note: Based on Megatron-LM MLA/YaRN RoPE behavior; exact upstream commit not identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The change follows Megatron-LM MLA/YaRN RoPE behavior; the exact upstream commit was not identified. This is related to NVIDIA/Megatron-LM#1418, which describes the dual meaning of max_position_embeddings for MLA YaRN RoPE.