Add information about supported Socrates version to docs #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Judging by the files listed in
src/extra/model/socrates/path_names&src/extra/model/socrates_column/path_namesand their commit history, the Socrates version Isca expects is1710. I have ran the test inexp/test_cases/socrates_testsuccessfully only with this version of Socrates, after trying several. However, the Isca docs suggest you should download the latest version of Socrates, which will not work - compilation will fail because the files in the latest version of Socrates (2507 at time of writing) differ from those listed in thesepath_namesfiles.It may be possible that, were these lists of filenames updated to match the latest version of Socrates, compilation would succeed, though I find it likely that at some point in the last eight years the parts of the Socrates code the Isca interface interacts with have changed (as well as the physical behaviour of the parametrisation itself). So, updating Isca to work with the latest version of Socrates may be a non-trivial piece of work. Telling people which version(s) of Socrates are supported, however, is easy, it's just the couple of lines of documentation changed in this PR.