Bump Onyx to version 3.0.14#74487
Conversation
|
|
|
@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ All modified and coverable lines are covered by tests. |
This comment has been minimized.
This comment has been minimized.
|
Reproduced #74385 in adhoc build 74385.mov |
situchan
left a comment
There was a problem hiding this comment.
You should also commit Podfile.lock changes (in Mobile-Expensify too) which came from version bump of react-native-nitro-sqlite
@situchan will do, once the previous Onyx bump is merged. |
cd97d45 to
ba644c9
Compare
|
@mountiny @situchan this should be ready for testing. I'll update the Onyx version to an actual version tag (instead of commit SHA) once Expensify/react-native-onyx#700 is merged |
|
@mountiny could you please trigger an ad-hoc build? |
|
Testing |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
I am still able to reproduce #74385 in adhoc build. Not happening on staging/production adhoc:
staging / production:
Edit: I reproduced on main as well so I can confirm that this was not caused by Onyx version bump |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariScreen.Recording.2025-11-10.at.8.49.51.PM.movMacOS: Chrome / SafariScreen.Recording.2025-11-10.at.8.47.50.PM.movMacOS: Desktop |
mountiny
left a comment
There was a problem hiding this comment.
Thanks everyone, please update the pods in oldApp too
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.55-3 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.57-0 🚀
|
|
Still very popular in production (https://expensify.sentry.io/issues/6971920940/events/3a1043f26ff44f3284ef07e7f196fa5b/), I'll keep on monitoring once we roll it out there. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|


@mountiny @shubham1206agra
Explanation of Change
Updates Onyx to version
3.0.14(not published yet) which requires a new version of NitroSQLite that introduces aDatabaseQueueimplementation, to prevent common errors around transactions in the Expensify app.More infos:
DatabaseQueueimplementation react-native-onyx#700DatabaseQueuefor transactions andexecuteBatchcommands margelo/react-native-nitro-sqlite#227Fixed Issues
$ #73793
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13768
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13771
Tests
Run QA tests on all app flows, to make sure Onyx works like expected.
[SqlExecutionError] cannot rollback - no transaction is active[SqlExecutionError] cannot start a transaction within a transactionOffline tests
None needed.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop