fix: change button color for one-button modals to grey#81374
fix: change button color for one-button modals to grey#81374daledah wants to merge 3 commits intoExpensify:mainfrom
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb5044f122
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| confirmText = '', | ||
| cancelText = '', | ||
| prompt = '', | ||
| success = true, | ||
| success = false, | ||
| danger = false, |
There was a problem hiding this comment.
Keep default success styling for multi-button modals
Changing the default success prop to false means any ConfirmModal/ConfirmContent caller that relies on the default (common in showConfirmModal flows) will now render a neutral/grey confirm button even when a cancel button is shown. That removes the primary emphasis between confirm vs. cancel and makes both actions look equivalent, which is a UX regression for two-button confirmations. If the intent is only to gray out one-button modals, the default should remain success or be conditional on shouldShowCancelButton rather than globally flipping the default.
Useful? React with 👍 / 👎.
Explanation of Change
Fixed Issues
$ #80929
PROPOSAL: #80929 (comment)
Tests
Cannot delete or disable all tagsis displayed andgot itbutton is greyOffline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-05.at.14.19.45.mov