Open
Conversation
Author
|
Is there any interest in this PR @tylerkaraszewski @johnmlee101 @quinthar or anyone else who’s active in this project? I also have a couple of others if someone can please take a look? #1077 #1076 |
Contributor
|
@tylerkaraszewski This might make sense now that #1906 has been merged? |
Contributor
|
I think I would do this differently, if we want it, probably with a specific flag to do this, possibly configuring logging to a particular file. We could clean up the command line documentation and options altogether if we want this, there are a fair number that are undocumented and some documented ones that don't do anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This feature adds support for console logging when running Bedrock without the
-forkstartup flag. This prevents the need to have to run an additional Syslog process when Bedrock is deployed in a Docker/Kubernetes environment.Fixed Issues
Fixes #101
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes