perf: add guard to skip subscriptions for invalid keys#695
Draft
waterim wants to merge 3 commits intoExpensify:mainfrom
Draft
perf: add guard to skip subscriptions for invalid keys#695waterim wants to merge 3 commits intoExpensify:mainfrom
waterim wants to merge 3 commits intoExpensify:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
fabioh8010
reviewed
Oct 29, 2025
Comment on lines
+232
to
+249
| // Fast path: if subscribing to a skippable collection member id, return undefined as loaded immediately | ||
| if (isFirstConnectionRef.current) { | ||
| try { | ||
| const [, memberId] = OnyxUtils.splitCollectionMemberKey(key); | ||
| if (OnyxUtils.getSkippableCollectionMemberIDs().has(memberId)) { | ||
| // Finalize initial state as loaded undefined and stop further first-connection flows | ||
| if (resultRef.current[1].status !== 'loaded' || resultRef.current[0] !== undefined) { | ||
| resultRef.current = [undefined, {status: 'loaded'}]; | ||
| onyxSnapshotCache.setCachedResult<UseOnyxResult<TReturnValue>>(key, cacheKey, resultRef.current); | ||
| } | ||
| isFirstConnectionRef.current = false; | ||
| shouldGetCachedValueRef.current = false; | ||
| return resultRef.current; | ||
| } | ||
| } catch (e) { | ||
| // Not a collection member, continue as usual | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can we avoid this? OnyxUtils.splitCollectionMemberKey isn't that cheap and getSnapshot is already pretty much heavy with lots of other logics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Eliminate wasted emissions and reduce callback storms by adding a guard that skips subscriptions for invalid keys like
undefinedornullRelated Issues
GH_LINK
Automated Tests
Manual Tests
Author Checklist
### Related Issuessection aboveTestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop