-
Notifications
You must be signed in to change notification settings - Fork 16
fix: Fixed convert chat type in method create_chat #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MOpryshko
wants to merge
3
commits into
ExpressApp:release-candidate
Choose a base branch
from
MOpryshko:fix/create_chat
base: release-candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -205,14 +205,12 @@ def test__create_chat_payload__convert_chat_type_validator() -> None: | |
| from pybotx.models.enums import ChatTypes, APIChatTypes | ||
|
|
||
| # Test with ChatTypes enum | ||
| values = {"chat_type": ChatTypes.GROUP_CHAT} | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(values) # type: ignore[operator] | ||
| assert result["chat_type"] == APIChatTypes.GROUP_CHAT | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(ChatTypes.GROUP_CHAT) # type: ignore[operator] | ||
| assert result == APIChatTypes.GROUP_CHAT | ||
|
|
||
| # Test with non-ChatTypes value (should remain unchanged) | ||
| values = {"chat_type": APIChatTypes.CHAT} # type: ignore[dict-item] | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(values) # type: ignore[operator] | ||
| assert result["chat_type"] == APIChatTypes.CHAT | ||
| result = BotXAPICreateChatRequestPayload._convert_chat_type(APIChatTypes.CHAT) # type: ignore[operator] | ||
| assert result == APIChatTypes.CHAT | ||
|
|
||
| # Test with missing chat_type key | ||
| values = {"name": "test"} # type: ignore[dict-item] | ||
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не совсем понимаю, зачем тестировать проткетед метод модели.
Это создает хрупкие тесты. Если ты станешь валидировать как-то по другому(например в рут валидаторе), то придется переписывать и этот тест.
К тому же, если кто-то вдруг нечаянно уберет декоратор с этого метода модели - тест все равно будет проходить .
Лучше протестировать всю работу создания модели, так будет надежнее.