VBat calibration & output only PWM validation#227
Open
pkendall64 wants to merge 2 commits into
Open
Conversation
CapnBry
approved these changes
Jun 9, 2026
CapnBry
left a comment
Member
There was a problem hiding this comment.
Oh hey, nice! I just assumed we'd leave the older hardware the same and the user would pick their own endpoints if they wanted to calibrate, but this is even better.
Can you verify my one comment where the atten was changed?
I will note that the ER6 and ER8 calibrations were done with a 300 point least-squares fit calibration to minimize error across the entire range and not just 2 end points, but I think the values are close enough that both are fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new hardware configuration validation
Updates all the existing targets to include the calibration values from the web sites and from previous known good values.