Skip to content

VBat calibration & output only PWM validation#227

Open
pkendall64 wants to merge 2 commits into
ExpressLRS:masterfrom
pkendall64:vbat-calibration
Open

VBat calibration & output only PWM validation#227
pkendall64 wants to merge 2 commits into
ExpressLRS:masterfrom
pkendall64:vbat-calibration

Conversation

@pkendall64

Copy link
Copy Markdown
Contributor

Adds new hardware configuration validation

  • "pwm_output_only" flag
  • "vbat_cal_min/max" for the calibration wizard
  • multiple voltage sources, vbat, vsrc1-3 including no_reading value

Updates all the existing targets to include the calibration values from the web sites and from previous known good values.

@CapnBry CapnBry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hey, nice! I just assumed we'd leave the older hardware the same and the user would pick their own endpoints if they wanted to calibrate, but this is even better.

Can you verify my one comment where the atten was changed?

I will note that the ER6 and ER8 calibrations were done with a 300 point least-squares fit calibration to minimize error across the entire range and not just 2 end points, but I think the values are close enough that both are fine.

Comment thread targets.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants