Skip to content

[+]: added method to add naughtly JS pattern #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intoeetive wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[+]: added method to add naughtly JS pattern #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,18 +154,23 @@ composer install
</td><td><a href="#addneverallowedoneventsafterwardsstring-strings-this">addNeverAllowedOnEventsAfterwards</a>
</td><td><a href="#addneverallowedregexstring-strings-this">addNeverAllowedRegex</a>
</td><td><a href="#addneverallowedstrafterwardsstring-strings-this">addNeverAllowedStrAfterwards</a>
</td></tr><tr><td><a href="#isxssfound-boolnull">isXssFound</a>
</td></tr><tr><td><a href="#addnaughtyjavascriptpatterns-strings-this">addNaughtyJavascriptPatterns</a>
</td><td><a href="#isxssfound-boolnull">isXssFound</a>
</td><td><a href="#removedonotclosehtmltagsstring-strings-this">removeDoNotCloseHtmlTags</a>
</td><td><a href="#removeevilattributesstring-strings-this">removeEvilAttributes</a>
</td><td><a href="#removeevilhtmltagsstring-strings-this">removeEvilHtmlTags</a>
</td></tr><tr><td><a href="#removeneverallowedcallstringsstring-strings-this">removeNeverAllowedCallStrings</a>
</td></tr><tr><td><a href="#removeevilhtmltagsstring-strings-this">removeEvilHtmlTags</a>
</td><td><a href="#removeneverallowedcallstringsstring-strings-this">removeNeverAllowedCallStrings</a>
</td><td><a href="#removeneverallowedjscallbackregexstring-strings-this">removeNeverAllowedJsCallbackRegex</a>
</td><td><a href="#removeneverallowedoneventsafterwardsstring-strings-this">removeNeverAllowedOnEventsAfterwards</a>
</td><td><a href="#removeneverallowedregexstring-strings-this">removeNeverAllowedRegex</a>
</td></tr><tr><td><a href="#removeneverallowedstrafterwardsstring-strings-this">removeNeverAllowedStrAfterwards</a>
</td></tr><tr><td><a href="#removeneverallowedregexstring-strings-this">removeNeverAllowedRegex</a>
</td><td><a href="#removeneverallowedstrafterwardsstring-strings-this">removeNeverAllowedStrAfterwards</a>
</td><td><a href="#setreplacementstring-string-this">setReplacement</a>
</td><td><a href="#setstripe4bytecharsbool-bool-this">setStripe4byteChars</a>
</td><td><a href="#xss_cleanstringstring-str-stringstring">xss_clean</a>
</td></tr><tr><td><a href="#xss_cleanstringstring-str-stringstring">xss_clean</a>
</td><td>
</td><td>
</td><td>
</td><td>
</td></tr></table>

## addDoNotCloseHtmlTags(string[] $strings): $this
Expand Down Expand Up @@ -264,6 +269,18 @@ Add some strings to the "_never_allowed_str_afterwards"-array.

--------

## addNaughtyJavascriptPatterns(string[] $strings): $this
<a href="#voku-php-readme-class-methods">↑</a>
Add some strings to the "_naughty_javascript_patterns"-array.

**Parameters:**
- `string[] $strings`

**Return:**
- `$this`

--------

## isXssFound(): bool|null
<a href="#voku-php-readme-class-methods">↑</a>
Check if the "AntiXSS->xss_clean()"-method found an XSS attack in the last run.
Expand Down
72 changes: 48 additions & 24 deletions src/voku/helper/AntiXSS.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,31 @@ final class AntiXSS
'xml',
];

/**
* @var string[]
*/
private $_naughty_javascript_patterns = [
'alert',
'prompt',
'confirm',
'cmd',
'passthru',
'eval',
'exec',
'execScript',
'setTimeout',
'setInterval',
'setImmediate',
'expression',
'system',
'fopen',
'fsockopen',
'file',
'file_get_contents',
'readfile',
'unlink',
];

/**
* @var string
*/
Expand Down Expand Up @@ -1724,30 +1749,8 @@ private function _sanitize_naughty_html_callback($matches)
private function _sanitize_naughty_javascript($str)
{
if (\strpos($str, '(') !== false) {
$patterns = [
'alert',
'prompt',
'confirm',
'cmd',
'passthru',
'eval',
'exec',
'execScript',
'setTimeout',
'setInterval',
'setImmediate',
'expression',
'system',
'fopen',
'fsockopen',
'file',
'file_get_contents',
'readfile',
'unlink',
];

$found = false;
foreach ($patterns as $pattern) {
foreach ($this->_naughty_javascript_patterns as $pattern) {
if (\strpos($str, $pattern) !== false) {
$found = true;

Expand All @@ -1757,7 +1760,7 @@ private function _sanitize_naughty_javascript($str)

if ($found === true) {
$str = (string) \preg_replace(
'#(?<!\p{L})(' . \implode('|', $patterns) . ')(\s*)\((.*)\)#uisU',
'#(?<!\p{L})(' . \implode('|', $this->_naughty_javascript_patterns) . ')(\s*)\((.*)\)#uisU',
'\\1\\2&#40;\\3&#41;',
$str
);
Expand Down Expand Up @@ -2002,6 +2005,27 @@ public function removeDoNotCloseHtmlTags(array $strings): self
return $this;
}

/**
* Add some strings to the "_naughty_javascript_patterns"-array.
*
* @param string[] $strings
*
* @return $this
*/
public function addNaughtyJavascriptPatterns(array $strings): self
{
if ($strings === []) {
return $this;
}

$this->_naughty_javascript_patterns = \array_merge(
$strings,
$this->_naughty_javascript_patterns
);

return $this;
}

/**
* Check if the "AntiXSS->xss_clean()"-method found an XSS attack in the last run.
*
Expand Down