refactor(pipeline): split effects.rs into focused sub-modules#624
Merged
Conversation
effects.rs had grown past the 1500-line guideline (1756 lines) with the crop/zoom work. Split it following the builder/ pattern — a pure move with only import/visibility adjustments, no logic changes: - effects/take.rs — the PGM take engine (trigger_transition) - effects/mixer_ops.rs — vision mixer runtime ops (bus selection, DSK, FTB, overlay alpha, PiP config, input resolutions) - effects/mixer_layout.rs — pad geometry/crop appliers shared by the take engine, mixer ops and the reactive geometry probe - effects/misc.rs — block-generic effects (animate input, loudness reset, recorder split, thumbnail capture) - effects/mod.rs — shared dist_canvas_size + crate-facing re-exports Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effects.rsgrew past the 1500-line guideline (1,756 lines) with the crop/zoom work in #622. This splits it into focused sub-modules following thebuilder/pattern — a pure move with only import/visibility adjustments, no logic changes:effects/take.rstrigger_transition, PiP-aware + classic paths)effects/mixer_ops.rseffects/mixer_layout.rseffects/misc.rseffects/mod.rsdist_canvas_size+ crate-facing re-exportsCrate-facing paths are unchanged (
crate::gst::pipeline::effects::{find_pad, apply_*}re-exported frommod.rs), sogeometry.rsand other consumers compile untouched.Test plan
cargo checkclean, zero unused-import warningspipeline_lifecycle_test(leak regression) green🤖 Generated with Claude Code