Refactor CLI and website; replace JSON configs#12
Open
Philip-Evans wants to merge 3 commits intoFAXES:mainfrom
Open
Refactor CLI and website; replace JSON configs#12Philip-Evans wants to merge 3 commits intoFAXES:mainfrom
Philip-Evans wants to merge 3 commits intoFAXES:mainfrom
Conversation
Convert JSON configs to JS modules and refactor both script and website code to use the new config objects. script/index.js and website/index.js were rewritten: synchronous file ops replaced with promise-based flows, improved logging and prompt helpers, better handling of compilation/backups via bytenode, and more robust directory/file processing. Update package.json files to remove/adjust unused deps (chalk removed, ejs and dependency list updated). Remove many placeholder README and legacy assets (including the large CSS file) and add small temp placeholder files where appropriate. Overall this streamlines config management and modernizes the compile/web workflows.
Owner
|
Looks good, only things I'd suggest is using lowercase in the folder names, I saw in the script capitalization is used which could cause issues cross-platform. And making the config file more generic as it appears they're set up for an existing project. |
Author
|
Thanks for the feedback! Good catch on the folder naming I’ll switch everything to lowercase to avoid any cross-platform issues. I’ll also refactor the config to make it more generic and not tied to the existing project setup. Appreciate you taking the time to review it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert JSON configs to JS modules and refactor both script and website code to use the new config objects. script/index.js and website/index.js were rewritten: synchronous file ops replaced with promise-based flows, improved logging and prompt helpers, better handling of compilation/backups via bytenode, and more robust directory/file processing. Update package.json files to remove/adjust unused deps (chalk removed, ejs and dependency list updated). Remove many placeholder README and legacy assets (including the large CSS file) and add small temp placeholder files where appropriate. Overall this streamlines config management and modernizes the compile/web workflows.