Conversation
Updated the detect_prob_curve module to enable probability of detection surface. POD surface uses flux and a meteo condition. This change enables both conditions to be recognized by FEAST
Corrected how detection_quantification module gets all the active emitters for the current time-step for site surveys and site monitors
The time module now accounts for a current time set to an arbitrary value. This allows for randomizing the start time of a simulation with an ad-hoc methodology, if need be.
Missed the plus 1 in the previous edit. This change reflects the need to capture active emissions throughout the current time-step. These emissions may begin prior to the current time-step and end in a future time-step, begin before the time-step and end in the current time-step, or begin in the current time-step and end in a future time-step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fixes for bugs encountered during the OGCI project