Skip to content

Fix crash when entering Mods menu with no mods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Krzyhau merged 1 commit into from
Jan 21, 2023
Merged

Fix crash when entering Mods menu with no mods #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions Installers/ModMenuInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,22 @@ private static void CreateAndAddModLevel(object MenuBase)
var MenuLevelAddItemGeneric = MenuLevelType.GetMethods().FirstOrDefault(mi => mi.Name == "AddItem" && mi.GetParameters().Length == 5);
var MenuLevelAddItemInt = MenuLevelAddItemGeneric.MakeGenericMethod(new Type[] { typeof(int) });

var menuIteratorItem = MenuLevelAddItemInt.Invoke(ModLevel, new object[] {
null, (Action)delegate { }, false,
(Func<int>) delegate{ return modMenuCurrentIndex; },
(Action<int, int>) delegate(int value, int change) {
modMenuCurrentIndex += change;
if (modMenuCurrentIndex < 0) modMenuCurrentIndex = Hat.Instance.Mods.Count-1;
if (modMenuCurrentIndex >= Hat.Instance.Mods.Count) modMenuCurrentIndex = 0;
}
});
MenuItemType.GetProperty("SuffixText").SetValue(menuIteratorItem, (Func<string>)delegate
if (Hat.Instance.Mods.Count > 0)
{
return $"{modMenuCurrentIndex + 1} / {Hat.Instance.Mods.Count}";
});
var menuIteratorItem = MenuLevelAddItemInt.Invoke(ModLevel, new object[] {
null, (Action)delegate { }, false,
(Func<int>) delegate{ return modMenuCurrentIndex; },
(Action<int, int>) delegate(int value, int change) {
modMenuCurrentIndex += change;
if (modMenuCurrentIndex < 0) modMenuCurrentIndex = Hat.Instance.Mods.Count-1;
if (modMenuCurrentIndex >= Hat.Instance.Mods.Count) modMenuCurrentIndex = 0;
}
});
MenuItemType.GetProperty("SuffixText").SetValue(menuIteratorItem, (Func<string>)delegate
{
return $"{modMenuCurrentIndex + 1} / {Hat.Instance.Mods.Count}";
});
}

Action<string, Func<string>> AddInactiveStringItem = delegate (string name, Func<string> suffix)
{
Expand All @@ -92,11 +95,18 @@ private static void CreateAndAddModLevel(object MenuBase)
}
};

AddInactiveStringItem(null, null);
AddInactiveStringItem(null, () => Hat.Instance.Mods[modMenuCurrentIndex].Info.Name);
AddInactiveStringItem(null, () => Hat.Instance.Mods[modMenuCurrentIndex].Info.Description);
AddInactiveStringItem(null, () => $"made by {Hat.Instance.Mods[modMenuCurrentIndex].Info.Author}");
AddInactiveStringItem(null, () => $"version {Hat.Instance.Mods[modMenuCurrentIndex].Info.Version}");
if (Hat.Instance.Mods.Count == 0)
{
AddInactiveStringItem(null, () => "No HAT Mods Installed");
}
else
{
AddInactiveStringItem(null, null);
AddInactiveStringItem(null, () => Hat.Instance.Mods[modMenuCurrentIndex].Info.Name);
AddInactiveStringItem(null, () => Hat.Instance.Mods[modMenuCurrentIndex].Info.Description);
AddInactiveStringItem(null, () => $"made by {Hat.Instance.Mods[modMenuCurrentIndex].Info.Author}");
AddInactiveStringItem(null, () => $"version {Hat.Instance.Mods[modMenuCurrentIndex].Info.Version}");
}

// add created menu level to the main menu
int modsIndex = ((IList)MenuLevelType.GetField("Items").GetValue(MenuRoot)).Count - 2;
Expand Down