...Or should we ask?#56
Open
emberling wants to merge 4 commits into
Open
Conversation
finally, the long-not-so-awaited mode to update pronouns to match character visuals. Bonus: Now with sons of submariners, sandworms, sandwiches, sphere grids, and all sorts of other S words!
this fix has been rotting in a branch since 2019. I looked into it and it seems like, if you had Terra swapped to vanilla Strago, for example, and not part of makeover, makeover would cull *Terra* clone sprites instead of *Strago* clone sprites. This .. should fix that issue? I'm pretty sure? Has that been an unreported bug for this long?
emberling/johnnydmad@6da7403 Fix assault length check to actually work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for adjusting script pronouns-n-such to match randomized appearance.
This is mostly just putting the system into place, as the majority of the script still needs to be added. Combat dialogue also is not handled yet.
Threw in some random bugfixes I noticed along the way as well.