Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the code by removing references to the HAPI FHIR server and adding a vm-setup script.
- Removed HAPI-related environment variables and service definitions from docker-compose.yml
- Updated README.md to remove HAPI references and include instructions to consult vm-setup.md for setup details
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose.yml | Removed HAPI and PostgreSQL commented service definitions and updated SUBDOMAINS environment variable |
| README.md | Removed HAPI server documentation and updated GCP instance requirements with vm-setup script reference |
Files not reviewed (2)
- .env-sample: Language not supported
- vm-setup.sh: Language not supported
Comments suppressed due to low confidence (1)
docker-compose.yml:30
- Consider permanently removing the commented-out HAPI and PostgreSQL service definitions if they are no longer needed rather than keeping them commented out.
# hapi:
Comment on lines
+16
to
18
| You have access to a GCP instance (minimum e2-small). | ||
| See vm-setup.md for details. | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider clarifying the resource requirements for the vm-setup script and explaining any potential trade-offs when using a smaller instance size compared to the previously suggested e2-highmem-2.
Suggested change
| You have access to a GCP instance (minimum e2-small). | |
| See vm-setup.md for details. | |
| You have access to a GCP instance. The minimum recommended instance size is `e2-small` (2 vCPUs, 2 GB memory), which is sufficient for basic usage. However, for better performance, especially when handling larger datasets or higher traffic, consider using a larger instance such as `e2-highmem-2` (2 vCPUs, 16 GB memory). | |
| **Trade-offs**: | |
| - Using a smaller instance (e.g., `e2-small`) reduces costs but may result in slower performance or insufficient resources for intensive tasks. | |
| - Using a larger instance (e.g., `e2-highmem-2`) increases costs but provides better performance and stability for resource-intensive operations. | |
| See vm-setup.md for detailed setup instructions and additional recommendations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR: