Skip to content

Conversation

@Tim-Grube
Copy link
Contributor

  • Variablen Deklaration so geändert, wie es in Einstiegsveranstaltungen gelehrt wird
  • Einen Test hotfix reingeworfen

@Tim-Grube Tim-Grube added enhancement fix_before_vorkurs25 Sollte am besten vor dem Vorkurs in 2025 gefixt werden testing Adding Tests labels Apr 15, 2025
@Tim-Grube Tim-Grube requested a review from fschledorn April 15, 2025 21:11
@Tim-Grube
Copy link
Contributor Author

Guys and !Guys I think the tests are working now...

@Tim-Grube
Copy link
Contributor Author

Wir haben vergessen die kaputten Files in _broken.cpp umzubennen, makes sense - machen wir wohl morgen dann

@Tim-Grube
Copy link
Contributor Author

We should probably add an explanation in the chapter somewhere, feel like someone with more knowledge should do that so Imma change the assignment

@fschledorn
Copy link
Member

Yup, I will start that later today probably. I'm gonna rebase the branch real quick before I forget to do that later on and we end up with another feaver dream

@fschledorn fschledorn force-pushed the change_variable_declaration branch from 9f92623 to b4148c5 Compare April 18, 2025 11:15
@Tim-Grube
Copy link
Contributor Author

Epiphany*

@Tim-Grube Tim-Grube marked this pull request as draft April 18, 2025 11:18
@fschledorn fschledorn marked this pull request as ready for review May 20, 2025 17:53
@fschledorn fschledorn self-requested a review May 20, 2025 17:53
Copy link
Member

@fschledorn fschledorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fschledorn fschledorn merged commit b1236c9 into new_features_2025 May 20, 2025
3 checks passed
@fschledorn fschledorn deleted the change_variable_declaration branch May 20, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement fix_before_vorkurs25 Sollte am besten vor dem Vorkurs in 2025 gefixt werden testing Adding Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants