-
Notifications
You must be signed in to change notification settings - Fork 19
[luv-434] audit poster restructure + dashboard restraint #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NiveditJain
wants to merge
28
commits into
main
Choose a base branch
from
luv-434-restructure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6c8c9c5
chore: stop ignoring .tmp/ (scratch demos land here)
nk-ag ddcedc6
docs: add audit poster restructure + dashboard restraint spec
nk-ag c8c6927
docs: revert /policies + /projects headings to plain title case
nk-ag f0240e2
style: calm site chrome + revert /policies + /projects to plain headings
nk-ag 79ac068
feat(audit): restructure into 5-section flow with shareable poster
nk-ag dbb2cd2
style(audit): strip dead CSS + brutalist treatments + lock poster to …
nk-ag 7af5d9d
style: drop body gradient + restructure how-to-improve as row list
nk-ag 35f5185
docs: changelog entry for audit poster restructure
nk-ag 356b042
style(audit): vertical centered poster + reorder tabs to projects/pol…
nk-ag 94477d8
fix(audit): clamp poster section to viewport so scroll hint fits the …
nk-ag 65e5370
fix(audit): score+rank no longer overlap; mono score font; calmer aut…
nk-ag 8b1385d
fix(audit): capture poster as rendered, drop .capturing override
nk-ag bc82999
fix(audit): flatten score row + use real logo on poster
nk-ag 8a5162f
fix(audit): swap html2canvas for html-to-image for clean PNG export
nk-ag a645249
fix(audit): lock html-to-image capture dims to live element so conten…
nk-ag 99279bd
docs: changelog entry for poster capture width lock
nk-ag 9c6d4da
docs: update dashboard.mdx for the new 5-section audit flow
nk-ag dfb7396
docs: changelog entry for dashboard.mdx audit-section update
nk-ag de018dd
fix(audit): capture poster from off-screen clone to drop flex-parent …
nk-ag 3ab6eb1
style(nav): drop ━━ glyph prefix + audit slipping-count badge
nk-ag 0308b73
fix: address CodeRabbit review — telemetry status, transient auth pro…
nk-ag 575d8d2
fix(audit): correct CLI binary name in how-to-improve install commands
nk-ag 0ff3767
feat(audit): invite-a-friend flow + spec for upstream /v0/invite endp…
nk-ag 9d6f541
docs: update dashboard.mdx + changelog for invite-a-friend flow
nk-ag c564f21
fix(audit-invite): handle 401 → re-auth, sanitize upstream errors, dr…
nk-ag a28539a
style(projects): rebuild ProjectList with calm chrome — sharp borders…
nk-ag 149e570
Revert "style(projects): rebuild ProjectList with calm chrome — sharp…
nk-ag 0d596de
style(project): calm /project/[name] header + SessionsList chrome
nk-ag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| /** | ||
| * POST /api/audit/invite | ||
| * | ||
| * Browser-facing proxy for the api-server's POST /v0/invite — the user | ||
| * supplies a list of friend emails, the api-server composes invite emails | ||
| * (Cc'ing the sender so the recipient sees who invited them), and dispatches | ||
| * them through the same email infrastructure that backs the OTP flow. | ||
| * | ||
| * Auth: requires an active session — same cookie/refresh-token contract as | ||
| * /api/auth/reminder. Anonymous calls get 401 so the front-end can route to | ||
| * the AuthDialog before retrying. | ||
| * | ||
| * Validation: max 10 recipients per call, each must look like an email. | ||
| * Anything beyond that gets a 400 and never reaches upstream. | ||
| * | ||
| * Contract for the upstream endpoint is handed over to the platform team | ||
| * separately. | ||
| */ | ||
| import { NextRequest, NextResponse } from "next/server"; | ||
| import { whoAmI } from "@/lib/auth/auth-store"; | ||
| import { AuthApiError, sendInvites } from "@/lib/auth/api-server-client"; | ||
| import { initTelemetry, trackEvent } from "@/lib/telemetry"; | ||
|
|
||
| export const dynamic = "force-dynamic"; | ||
|
|
||
| const MAX_RECIPIENTS = 10; | ||
| const EMAIL_RE = /^[^\s@]+@[^\s@]+\.[^\s@]+$/; | ||
|
|
||
| interface InviteBody { | ||
| to?: unknown; | ||
| } | ||
|
|
||
| export async function POST(req: NextRequest): Promise<NextResponse> { | ||
| await initTelemetry(); | ||
| const who = await whoAmI(); | ||
| if (!who) { | ||
| trackEvent("audit_invite_sent", { status: "unauthorized", source: "dashboard" }); | ||
| return NextResponse.json( | ||
| { code: "unauthorized", message: "Sign in before sending invites." }, | ||
| { status: 401 }, | ||
| ); | ||
| } | ||
|
|
||
| let body: InviteBody = {}; | ||
| const raw = await req.text(); | ||
| if (raw.trim().length > 0) { | ||
| try { | ||
| const parsed = JSON.parse(raw); | ||
| if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed)) { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "validation_error", | ||
| source: "dashboard", | ||
| reason: "not_an_object", | ||
| user_id: who.me.id, | ||
| }); | ||
| return NextResponse.json( | ||
| { code: "validation_error", message: "Request body must be a JSON object." }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
| body = parsed as InviteBody; | ||
| } catch { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "validation_error", | ||
| source: "dashboard", | ||
| reason: "malformed_json", | ||
| user_id: who.me.id, | ||
| }); | ||
| return NextResponse.json( | ||
| { code: "validation_error", message: "Request body is not valid JSON." }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| if (!Array.isArray(body.to)) { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "validation_error", | ||
| source: "dashboard", | ||
| reason: "missing_to", | ||
| user_id: who.me.id, | ||
| }); | ||
| return NextResponse.json( | ||
| { code: "validation_error", message: "`to` must be a list of email addresses." }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
|
|
||
| const normalised: string[] = []; | ||
| const seen = new Set<string>(); | ||
| for (const entry of body.to) { | ||
| if (typeof entry !== "string") continue; | ||
| const e = entry.trim().toLowerCase(); | ||
| if (!e || !EMAIL_RE.test(e)) continue; | ||
| if (e === who.me.email.toLowerCase()) continue; // can't invite yourself | ||
| if (seen.has(e)) continue; | ||
| seen.add(e); | ||
| normalised.push(e); | ||
| } | ||
|
|
||
| if (normalised.length === 0) { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "validation_error", | ||
| source: "dashboard", | ||
| reason: "no_valid_recipients", | ||
| user_id: who.me.id, | ||
| input_count: Array.isArray(body.to) ? body.to.length : 0, | ||
| }); | ||
| return NextResponse.json( | ||
| { | ||
| code: "validation_error", | ||
| message: "Provide at least one valid email address (other than your own).", | ||
| }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
|
|
||
| if (normalised.length > MAX_RECIPIENTS) { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "validation_error", | ||
| source: "dashboard", | ||
| reason: "too_many_recipients", | ||
| user_id: who.me.id, | ||
| input_count: normalised.length, | ||
| }); | ||
| return NextResponse.json( | ||
| { | ||
| code: "validation_error", | ||
| message: `Up to ${MAX_RECIPIENTS} recipients per invite batch. Please send the rest in a follow-up.`, | ||
| }, | ||
| { status: 400 }, | ||
| ); | ||
| } | ||
|
|
||
| try { | ||
| const result = await sendInvites(who.auth.access_token, normalised); | ||
| trackEvent("audit_invite_sent", { | ||
| status: "success", | ||
| source: "dashboard", | ||
| user_id: who.me.id, | ||
| sent_count: result.sent.length, | ||
| failed_count: result.failed.length, | ||
| }); | ||
| return NextResponse.json(result, { status: 200 }); | ||
| } catch (err) { | ||
| if (err instanceof AuthApiError) { | ||
| trackEvent("audit_invite_sent", { | ||
| status: "failed", | ||
| source: "dashboard", | ||
| user_id: who.me.id, | ||
| error_code: err.code, | ||
| http_status: err.status, | ||
| recipient_count: normalised.length, | ||
| }); | ||
| const httpStatus = err.status >= 200 && err.status < 600 ? err.status : 504; | ||
| return NextResponse.json( | ||
| { | ||
| code: err.code, | ||
| message: err.message, | ||
| ...(err.retryAfterSecs !== undefined ? { retry_after_secs: err.retryAfterSecs } : {}), | ||
| }, | ||
| { status: httpStatus }, | ||
| ); | ||
| } | ||
| // Don't surface the raw upstream message to either telemetry or the | ||
| // client. Network/DNS errors can carry internal hostnames, IPs, or | ||
| // fragment payload bytes that have no business leaving the proxy. | ||
| // Log the error name only (bounded) and return a stable generic. | ||
| const errorName = err instanceof Error ? err.name : "unknown"; | ||
| trackEvent("audit_invite_sent", { | ||
| status: "failed", | ||
| source: "dashboard", | ||
| user_id: who.me.id, | ||
| error_code: "upstream_unreachable", | ||
| error_name: errorName.slice(0, 50), | ||
| recipient_count: normalised.length, | ||
| }); | ||
| return NextResponse.json( | ||
| { code: "upstream_unreachable", message: "Invite service is unreachable. Please try again in a moment." }, | ||
| { status: 502 }, | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.