fix: opt into fixed klog stderrthreshold behavior#596
Open
pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
Open
fix: opt into fixed klog stderrthreshold behavior#596pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
Conversation
After klog.InitFlags(), set legacy_stderr_threshold_behavior=false and stderrthreshold=INFO so that klog honors the stderrthreshold flag correctly (kubernetes/klog#212). The repo already uses klog/v2 v2.140.0, so no dependency bump is needed. Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
|
|
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klog.InitFlags(), setlegacy_stderr_threshold_behavior=falseandstderrthreshold=INFOso that klog honors thestderrthresholdflag correctly.stderrthresholdwas effectively ignored.k8s.io/klog/v2 v2.140.0.Why
Without this fix, all log messages (including low-severity ones) are written to stderr regardless of the
stderrthresholdsetting. The newlegacy_stderr_threshold_behaviorflag was introduced in klog v2.140.0 to allow consumers to opt into the corrected behavior without breaking existing deployments.Test plan
go build ./...)/cc @sudermanjr @rbren