ci: extend windows-latest + macos-latest push triggers to release/v*#297
Merged
Merged
Conversation
Closes #293. Parity follow-up to #291 (which extended PR-validation triggers to release/v*). After this: - windows-latest.yml — pull_request trigger unchanged (still PR-only on main, by design); push trigger extends to main AND release/v*. - macos-latest.yml — same. - build/Build.CI.GitHubActions.cs — OnPushBranches on both windows and macos [GitHubActions] entries gain ReleaseBranchPattern alongside MainBranch, so next auto-regen produces matching YAML. Effect: a hotfix merged to release/v11 now triggers Windows + macOS post-merge validation, same as merges to main. Cross-platform regressions in release-branch hotfixes surface immediately as red commits on the release branch, not later when someone tries to cut a release. Out of scope: extending pull_request triggers on windows/macos to fire on release/v* PRs. The current PR gate (ubuntu-latest only) is a deliberate cost trade-off documented in docs/agents/release-and-versioning.md. Refs milestone #13. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #293. Parity follow-up to #291, which extended PR-validation triggers to
release/v*but deliberately left push triggers alone.Why
After #291 + #292, PRs against
release/v*getubuntu-latest. But post-merge cross-platform validation (windows-latest+macos-latest) still only fires on push tomain. A hotfix landing onrelease/v11with a subtle Windows or macOS regression wouldn't be caught until someone attempts a release and the cross-platform CI inrelease.yml's Test step fails — higher-stakes path, harder to fix forward.What changes
build/Build.CI.GitHubActions.cs—OnPushBrancheson bothwindows-latestandmacos-latest[GitHubActions]entries now readsnew[] { MainBranch, ReleaseBranchPattern }.ReleaseBranchPatternwas added in ci: extend PR-validation triggers to release/v* branches #291 alongsideMainBranch..github/workflows/windows-latest.yml—push.branchesadds'release/v*'..github/workflows/macos-latest.yml— same.YAML hand-edited to match the source — next time someone runs
dotnet fallout --generate-configuration GitHubActions_windows-latest GitHubActions_macos-latest, the regen produces identical output.Effect
A hotfix merged to
release/v11now fires Windows + macOS post-merge validation. Cross-platform regressions surface immediately as a red commit on the release branch, not later during a release attempt.Out of scope
main. The current PR gate (ubuntu-latestonly) is a deliberate cost trade-off documented indocs/agents/release-and-versioning.md— Linux is the cheap, fast feedback loop; Windows/macOS are reserved for post-merge.Test plan
Refs milestone #13.
🤖 Generated with Claude Code