Convert :complete to CompleteCommand (#392)#396
Open
ChrisonSimtian wants to merge 2 commits into
Open
Conversation
ChrisonSimtian
added
the
target/2026
ChrisonSimtian
force-pushed
the
cli-cmd-complete
branch
from
c7cfea3 to
599c2d6
Compare
ChrisonSimtian
changed the base branch from
cli-command-dispatch-foundation
to
cli-cmd-trigger
Lift the shell-completion handler off Program into a standalone IFalloutCommand type and register it directly, replacing its DelegateCommand adapter. Part of the Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Name resolution plus the null-root and non-fallout-command-line early returns. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
cli-cmd-complete
branch
from
599c2d6 to
8e61aa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #392 (one command per PR). Stacked on #394 — merge after it lands.
Lifts
:complete(shell-completion) intoCompleteCommand : IFalloutCommand, registered directly; removes itsDelegateCommandadapter and deletesProgram.Complete.cs. Self-contained. Name/behaviour unchanged.🤖 Generated with Claude Code