Convert :add-package to AddPackageCommand (#392)#398
Open
ChrisonSimtian wants to merge 1 commit into
Open
Conversation
ChrisonSimtian
added
the
target/2026
ChrisonSimtian
force-pushed
the
cli-cmd-add-package
branch
from
88bacb9 to
7dd6e1c
Compare
ChrisonSimtian
changed the base branch from
cli-command-dispatch-foundation
to
cli-cmd-get-configuration
ChrisonSimtian
force-pushed
the
cli-cmd-get-configuration
branch
from
5ba1600 to
1c98a9a
Compare
Lift the :add-package handler into a standalone IFalloutCommand type. The shared AddOrReplacePackage helper and PACKAGE_TYPE_*/BUILD_PROJECT_FILE constants stay on Program as residual (still used by cake and tests) until the #392 collapse PR moves them into services. Replaces the DelegateCommand adapter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
cli-cmd-add-package
branch
from
7dd6e1c to
2ca801b
Compare
Collaborator
Author
|
Testing note: no command unit test in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #392 (one command per PR). Stacked on #394 — merge after it lands.
Lifts
:add-packageintoAddPackageCommand : IFalloutCommand. The sharedAddOrReplacePackagehelper andPACKAGE_TYPE_*/BUILD_PROJECT_FILEconstants stay onProgramas residual (still used by cake + the Cake tests) until the collapse PR (#404). Replaces theDelegateCommandadapter. Name/behaviour unchanged.🤖 Generated with Claude Code