Rebrand the global-tool startup banner from NUKE to Fallout#422
Merged
Conversation
3ee3a82 to
bed618e
Compare
bed618e to
c14593f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The CLI's startup banner still printed
NUKE Global Tool 🌐:Changed to
Fallout Global Tool 🌐.Why
A leftover the command/package rebrand missed — #66 renamed the command (
nuke→fallout) and #371 publishes the package asFallout.GlobalTools, but this runtime banner literal was never updated. It's the first line a user sees on everydotnet falloutinvocation.Note for the in-flight CLI refactors
The same literal is currently carried forward (unchanged) by the open refactor PRs:
cli-cmd-collapse) moves it intoCliConventions.csasToolBannercli-cmd-navigation) leaves it inProgram.csWhichever lands first, the string should end up as
Fallout Global Tool 🌐. Trivial conflict either way — flagging so it isn't silently re-introduced.