Handle missing changelog (sections) during pack#433
Open
dennisdoomen wants to merge 2 commits into
Open
Conversation
b7755c4 to
8920223
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8920223 to
093cbde
Compare
Collaborator
There was a problem hiding this comment.
ah yes, thats probably the way. Fault tolerant, if its not there skip.
Mind to call the logger to spit out a warning? I'd expect if someone calls the Changelog Task they intend to write it (which in our case was the actual issue, we didnt fully remove it from our internal build process before I killed the Changelog.md)
ChrisonSimtian
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
build/_build.csproj) is intentionally marked as not built in the solution so it is exercised via the build entrypoint (./build.ps1/./build.sh) rather than as a normal solution build target.Combined effect
Validation
dotnet test tests/Fallout.Common.Tests/Fallout.Common.Tests.csproj --filter ChangelogTasksTestNote The failing build was caused by #375, but wasn't caught by GHA as that one skips changes to doc files.