Skip to content

Handle missing changelog (sections) during pack#433

Open
dennisdoomen wants to merge 2 commits into
Fallout-build:mainfrom
dennisdoomen:pack-analysis
Open

Handle missing changelog (sections) during pack#433
dennisdoomen wants to merge 2 commits into
Fallout-build:mainfrom
dennisdoomen:pack-analysis

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make pack resilient when no changelog release sections are available.
  • Add regression coverage for a missing changelog file.
  • Clarify that the build entrypoint project is intentionally excluded from solution builds.

Changes

  • Handle missing changelog sections during pack
    • Return empty release notes when the changelog file is missing or contains no release sections, avoiding the pack-time exception.
  • Adjust solution build settings
    • Keep the solution file aligned with the current build configuration for this PR branch.
    • The build entrypoint project (build/_build.csproj) is intentionally marked as not built in the solution so it is exercised via the build entrypoint (./build.ps1 / ./build.sh) rather than as a normal solution build target.

Combined effect

  • Pack no longer fails just because the changelog is absent or empty, and the PR history is split into focused commits.

Validation

  • dotnet test tests/Fallout.Common.Tests/Fallout.Common.Tests.csproj --filter ChangelogTasksTest

Note The failing build was caused by #375, but wasn't caught by GHA as that one skips changes to doc files.

@dennisdoomen dennisdoomen requested a review from a team as a code owner June 26, 2026 06:48
@dennisdoomen dennisdoomen force-pushed the pack-analysis branch 2 times, most recently from b7755c4 to 8920223 Compare June 26, 2026 06:53
dennisdoomen and others added 2 commits June 26, 2026 08:54
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dennisdoomen dennisdoomen added target/2026 Targets the 2026 calendar-version line (current). See ADR-0004. bug Something isn't working labels Jun 26, 2026
@dennisdoomen dennisdoomen changed the title Handle missing changelog sections during pack Handle missing changelog (sections) during pack Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thats probably the way. Fault tolerant, if its not there skip.
Mind to call the logger to spit out a warning? I'd expect if someone calls the Changelog Task they intend to write it (which in our case was the actual issue, we didnt fully remove it from our internal build process before I killed the Changelog.md)

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'd throw a warning ala

Warning: You called the Changelog Task but we couldnt find a changelog.md

And then we can either create one (I'd rather not) or the user at least sees why we didnt write anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working target/2026 Targets the 2026 calendar-version line (current). See ADR-0004.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants