[SM64] fix Whirlpool Object export for decomp/ultrasm64#456
Open
s4Ys369 wants to merge 3 commits intoFast-64:mainfrom
Open
[SM64] fix Whirlpool Object export for decomp/ultrasm64#456s4Ys369 wants to merge 3 commits intoFast-64:mainfrom
s4Ys369 wants to merge 3 commits intoFast-64:mainfrom
Conversation
Lilaa3
reviewed
Sep 12, 2024
Lilaa3
requested changes
Sep 12, 2024
Comment on lines
+2906
to
+2908
| bpy.types.Object.whirlpool_index = bpy.props.StringProperty(name="Index", default="0") | ||
| bpy.types.Object.sm64_whirlpool_enum = bpy.props.EnumProperty(name="Condition", items=enumWhirlpoolConditions) | ||
| bpy.types.Object.whirlpool_strength = bpy.props.StringProperty(name="Strength", default="20") |
Collaborator
There was a problem hiding this comment.
New props should be in their respective property groups, in this case these properties would be in ̶S̶M̶6̶4̶_̶G̶a̶m̶e̶O̶b̶j̶e̶c̶t̶P̶r̶o̶p̶e̶r̶t̶i̶e̶s̶ actually maybe it should be a prop group in SM64_ObjectProperties? techinically whirlpools are objects lol
Contributor
Author
There was a problem hiding this comment.
I haven't look into this in months, so out of my depth.
I should just revert the changes and fix the existing typos to restore functionality.
Collaborator
There was a problem hiding this comment.
I'll pr that change to your branch once I'm done reviewing scut's geolayout opt pr if you'd like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is meant for the vanilla whirlpool level command, which is condition based. HackerSM64's whirlpools are act based and I could add the act selector, but as the command may soon be deprecated, I opted to allow the user to enter a custom condition for the time being instead.