[SM64] Animations Rewrite/Rework#467
Conversation
|
import c animations actually fucking work, i worship lila from now on, W Lila |
avereyishere
left a comment
There was a problem hiding this comment.
Animation I/O works from C to Binary and the false bounds detection works
|
You mention this is based on other PRs, so are these other PRs to be merged first? |
YoshiMilkman
left a comment
There was a problem hiding this comment.
Works great. Been using it for DMA animation exporting with a custom Mario rig. Nothing else in Fast64 seems broken. Been using for a few weeks now.
Ideally, obviously no pressure since the smart includes pr is niche, i just incorporated it for the simple actor include write function (oh and the useful functions for the table update function!) |
|
Also worth mentioning that I could always remove non animation data from the actor presets until we actually use them, I just thought scut would benifit from them in her importer pr #198 |
Reonu
left a comment
There was a problem hiding this comment.
I've been on this branch for a while and everything seems okay, I used it to develop the entire desert mario 2 hack
Verbose documentation like docstrings is.. not my strong suite
|
Why's this still not merged? |
|
....... |
jesusyoshi54
left a comment
There was a problem hiding this comment.
Basically good, seems like people have tested it a bunch so that is a good sign that it works.
fast64_internal/sm64/README.md
Outdated
|
|
||
| ### Animating Existing Geolayouts | ||
| Often times it is hard to rig an existing SM64 geolayout, as there are many intermediate non-deform bones and bones don't point to their children. To make this easier you can use the 'Create Animatable Metarig' operator in the SM64 Armature Tools header. This will generate a metarig which can be used with IK. The metarig bones will be placed on armature layers 3 and 4. | ||
| ### TODO: Link to animations docs |
There was a problem hiding this comment.
When are you going to do this?
There was a problem hiding this comment.
There was a problem hiding this comment.
And here is the page https://fast64--7.org.readthedocs.build/en/7/
|
yay! |
Wouldn't it be funny if this was approved, just like, instantly
Based on prs: #449 , #393, #450
Fully rewriten animation exporter and importer, with some code I'm proud of and some code I probably kept from a year ago (be harsh as needed)
anim_test_impor_allt_script.py for testing all import presets
TODO (up for review because code is "done" (as in if I keep trying to find issues on my own for the next months I'll cry)):