[OoT] Fix room's object list display issue#488
Open
Yanis002 wants to merge 2 commits intoFast-64:mainfrom
Open
[OoT] Fix room's object list display issue#488Yanis002 wants to merge 2 commits intoFast-64:mainfrom
Yanis002 wants to merge 2 commits intoFast-64:mainfrom
Conversation
Yanis002
added
bug
Collaborator
|
Waiting on answer/change to my question in the dev channel
|
Collaborator
Author
|
this happens to be an issue I fixed recently, fixing the conflicts solved your question I think that's hilarious actually, I think what this was fixing was the thing reonu found recently but since it got fixed separately now this PR only fix the object list UI issue lol |
Yanis002
changed the title
Dragorn421
reviewed
May 19, 2025
Comment on lines
+52
to
+54
| elif self.objectKey == "": | ||
| # just in case there's invalid objects keys, allows users to delete them | ||
| objectName = "DELETE ME!" |
Contributor
There was a problem hiding this comment.
since "" is not a valid value for objectKey I don't understand how this can happen
The id for deleted entries (see self.deletedEntry in OoT_ObjectData.__init__) is "None", maybe that's what should be checked here instead?
Or self.objectKey not in ootData.objectData.objectsByKey ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found two minor issues, the first one is a bug causing the draw to fail if an object has an empty key value, and while investigating this I found another one where rotations would look for an actor's type without checking if it's using one, which caused another bug with the UI
"fixed" the first one by simply checking if the key is empty, and draw a "delete me" label so users can delete the wrong entries (still no idea how it happened though), and fixed the second one simply by checking if the type is used (now that I think about this might not work after all?)