Skip to content

[F3D] Fix final revert deduplication#656

Merged
Lilaa3 merged 2 commits intoFast-64:mainfrom
Anoliah:final-revert-fix
Jan 24, 2026
Merged

[F3D] Fix final revert deduplication#656
Lilaa3 merged 2 commits intoFast-64:mainfrom
Anoliah:final-revert-fix

Conversation

@Anoliah
Copy link
Contributor

@Anoliah Anoliah commented Jan 24, 2026

Final reverts displaylists that had duplicated names were not getting their namePrefix appended to the deduplicated name. Fixed to use final_name instead.
Fixes #655

Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would continously add more _00n to the name until it didn't match. There needs to be an initial value to append the number string to

@Anoliah Anoliah requested a review from Lilaa3 January 24, 2026 17:42
@Anoliah
Copy link
Contributor Author

Anoliah commented Jan 24, 2026

Should be fixed now

@Lilaa3 Lilaa3 merged commit 54fe8bb into Fast-64:main Jan 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SM64] final reverts export without unique names in levels with multiple areas

2 participants