Skip to content

Conversation

@MichaelAnders
Copy link
Contributor

Reverts #20 - somehow my code went totally wrong, need to fix it

@MichaelAnders
Copy link
Contributor Author

Will fix the issues with a new PR

@hillct
Copy link
Contributor

hillct commented Jan 26, 2026

@MichaelAnders you cabn't close this ticket without the merge being completed. @vishalveerareddy123 Please complete the reversion, so the application can at last be launches without errors. While I haven't reviewed the entire commit that causd this problem, the mininal fix is to remove two lines from Orchistrator/index.js https://github.com/Fast-Editor/Lynkr/blob/main/src/orchestrator/index.js#L14 and https://github.com/Fast-Editor/Lynkr/blob/main/src/orchestrator/index.js#L16 which both try to require modules that do not exist and methods that are never used. There are probably other issues with this commit, as @MichaelAnders alludes to, but these are the minimal issues preventing application startup. I'm sure we can all agree, actually launching the application, to confirm proper operation, beyond running the unit tests, is advisable, before committing changes, and definately, before merging a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants