Fix audit logging #27
Open
+3,100
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: PR Fast-Editor#20 introduced new code but unintentionally introduced inconsistent code. Changes implemented: 1. Files cleaned up 2. Missing dns-logger.js added 3. New code added Testing: success: npm run test:unit success: Claude connects to Lynkr correctly
Collaborator
|
Thanks @MichaelAnders I will take a look at this one today |
Integrates the audit logging infrastructure with the orchestrator's runAgentLoop function to capture all LLM request/response pairs for compliance and debugging purposes. Changes: - Add crypto module import for correlation ID generation - Add getDestinationUrl() helper to resolve provider endpoints - Instantiate audit logger at the start of runAgentLoop - Log LLM requests before invokeModel() with correlation IDs - Log LLM responses after invokeModel() with token usage and latency - Handle streaming, success, and error response cases - Add logs/ directory to .gitignore The audit logger is a no-op when disabled, ensuring zero overhead when not in use. All logs use structured JSON format with correlation IDs to link request/response pairs. Implements plan from PR Fast-Editor#27 for intelligent audit logging.
Contributor
Author
|
I have added the missing code as my plans for the next 3 days have changed this morning. Testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: PR #20 introduced new code but unintentionally introduced inconsistent code.
Changes implemented:
Testing:
success: npm run test:unit
success: Claude connects to Lynkr correctly
Remaining task for me (delayed due to time constraints on my end):