This repository was archived by the owner on Apr 6, 2022. It is now read-only.
Fixing issue: #45 Invalid URL in region us-east-1#46
Open
Teippo2020 wants to merge 4 commits into
Open
Conversation
Fixing issue: Fausto95#45 When the region is `us-east-1` the URL should be built in another way than the other regions (regions in China do not apply this rule)
Owner
|
Can you please update your branch and keep the switch statement instead of the if statement |
Author
|
I don't see any problem using the if statement, besides, we use two different variables |
Owner
|
Using |
|
FYI - at the rate this is maintained, you're best off using the plain-jane |
Contributor
|
@Fausto95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue: #45
When the region is
us-east-1the URL should be built in another way than the other regions (regions in China do not apply this rule)