Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Fixing issue: #45 Invalid URL in region us-east-1#46

Open
Teippo2020 wants to merge 4 commits into
Fausto95:masterfrom
Teippo2020:patch-1
Open

Fixing issue: #45 Invalid URL in region us-east-1#46
Teippo2020 wants to merge 4 commits into
Fausto95:masterfrom
Teippo2020:patch-1

Conversation

@Teippo2020
Copy link
Copy Markdown

Fixing issue: #45
When the region is us-east-1 the URL should be built in another way than the other regions (regions in China do not apply this rule)

Fixing issue: Fausto95#45
When the region is `us-east-1` the URL should be built in another way than the other regions (regions in China do not apply this rule)
@Fausto95
Copy link
Copy Markdown
Owner

Can you please update your branch and keep the switch statement instead of the if statement

@Teippo2020
Copy link
Copy Markdown
Author

I don't see any problem using the if statement, besides, we use two different variables countryCode and region. I think an if/else seems more readable than a switch in this case.

@Fausto95
Copy link
Copy Markdown
Owner

Fausto95 commented Mar 1, 2019

Using countryCode is the better way IMO,
case countryCode === us then format the url

@jpwiddy
Copy link
Copy Markdown

jpwiddy commented Jun 4, 2019

FYI - at the rate this is maintained, you're best off using the plain-jane aws-sdk

@wvicioso
Copy link
Copy Markdown
Contributor

@Fausto95 Switch won't work in this case since we are only aware 'us-east-1' causes the problem. using countryCode === 'us' might raise issues for other users

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants